feat(video3d): ampliar plantillas y añadir velocidad y gizmo de edición - #249
Merged
Conversation
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.8/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.1 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
IAnMove
marked this pull request as ready for review
September 7, 2026 23:05
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_0ca90f4d-8110-4994-aca7-21ad643ffdee) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
El botón de reproducir de Vídeo 3D quedaba perdido entre las cámaras y los objetos sólo tenían campos diminutos y un arrastre sin ejes. Ahora el editor dispone de una barra visible, velocidad común a preview y MP4, y gizmo para mover y escalar objetos.
Base de integración local:
df87153c(incluye #240). HEAD:cda61b4622a341f134b0a31c22be6519ef714b9a. Worktree aislado; sin cambios en launchers, servicios activos ni medios versionados.Validación local:
test_scene_recording.py,test_architecture_contracts.py).df87153cpasa. Sin cambiar baselines.Límites: WebGL probado con geometría de muestra y API simulada en puerto aislado; no valida artísticamente todos los planos con GLB del usuario ni ejecuta proveedores. Las plantillas configuran cámaras/luces/slots; los clips esqueléticos se asignan desde los GLB existentes. Giro limitado a Y conforme al documento. CI y revisión técnica independiente del HEAD quedan pendientes; PR draft, sin merge ni publicación.
Detalle del contrato:
docs/development/VIDEO3D_EDITOR_REFRESH.md.Note
Medium Risk
Changes MP4 export timing, recording metadata, and WebGL transform interaction alongside a large template catalog expansion; behavior is heavily tested but regressions would affect published videos and editor state.
Overview
Refreshes the Video 3D editor with a clearer transport bar (large Play/Pause, seek, restart, 0.25×–4× speed shared by preview and MP4 export), a collapsible searchable shot library (36 templates with per-shot camera/light profiles and ES/EN copy), fullscreen focus mode, and Three.js gizmo editing (move X/Y/Z, yaw, uniform scale) wired to numeric controls and disabled during play/export.
Adds optional
playbackSpeedonScene3DDocument: timeline length staysduration, but output length and encoder timing useduration / playbackSpeed; publish metadata now carries the full document and effective video duration. Template switches can keep compatible GLB sources, refs, and clip choices viaremountScene3DTemplateand retained clip catalogs.For the 48 layer-based candidate templates, new compiles apply an editable depth finish (
finishVersion: 1) without changing prompts or stored references; template galleries gain search and larger play affordances, with a matching preview button bump in the scene animator.Coverage includes directed unit tests, new Playwright flows (gizmo drag, mobile layout, H.264 export at 4×), and
docs/development/VIDEO3D_EDITOR_REFRESH.md.Reviewed by Cursor Bugbot for commit cda61b4. Configure here.